mgrrx
commented
7 years ago First of all I'd like to say thank you for providing this pull request! But unfortunately we will not merge this one as we have a few objections here.
This package was released in coordination with Basler. As they want to keep control over their releasing and packaging process (which is at the moment zip-only) we did not package the SDK on our own. In the future they might want to release Debian packages. Therefore we are asked to stick to the standard workflow that Basler suggests. And as you already know, the current mechanism here is to download the zip to e.g. /opt/pylon5 and adapt the environment variables accordingly. The solution you proposed would cause problems when used in combination with a separate Basler SDK in /opt/pylon5. First, with this PR you are not shipping e.g. the PylonViewerApp, so the user would need to to download the SDK anyway. In the end, he would have different versions on his PC and might have issues with the SDK that are purely related to this mixture of libraries and headers. The current solution we have (using rosdep to download the SDK to /opt if necessary) gives full flexibility to the user.
As you already released the package on your own I added some comments in the PR.
Changes:
I think this method is better than the rosdep method described on the wiki. The SDK is installed relative to the ROS installation, so it won't affect users with a manually installed SDK.
Now this package can be build as a binary Debian package on the buildfarm
http://wiki.ros.org/bloom/Tutorials/FirstTimeRelease
I built Debian packages for Indigo and Kinetic on Dataspeed's buildfarm
https://bitbucket.org/DataspeedInc/ros_binaries