search

magazino / pylon_camera

ROS-Driver for Basler Cameras
BSD 3-Clause "New" or "Revised" License
78 stars 108 forks source link

framerate is ignored when it is less than the maximum supported framerate #42

Open csukuangfj opened 6 years ago

csukuangfj commented 6 years ago

See the config file https://github.com/magazino/pylon_camera/blob/ea4d9438b8351b6577dc1fd2bd29d961c21415db/config/default.yaml#L31-L34

and the code https://github.com/magazino/pylon_camera/blob/ea4d9438b8351b6577dc1fd2bd29d961c21415db/src/pylon_camera/pylon_camera_node.cpp#L331-L348

When the framerate is less than maxPossibleFramerate, it is ignored!

There should be another if to set the desired framerate when it is a valid value, i.e., in the range [1, maxPossibleFramerate].