Adding RGB8 Support - Githubissues

kmalhan commented 7 years ago

I have made following changes to add RGB8 support and enhance existing features.

Added RGB8 encoding support. User can choose between MONO8 and RGB8 by setting parameter (pixel_encoding) in launch file.
Rectify image only if camera is calibrated and image_rect is subscribed by other nodes.
User can perform camera calibration to create new calibration file or update existing calibration file.
Added a few optional parameters for USB camera which are used when RGB8 encoding is selected.

I have tested the changes with Basler daA1600-60uc. I have not tested with GigE cameras as I don't own one. Please review the changes.

NikolasE commented 7 years ago

Thank you for your work. It's a bit difficult to check your changes as your pull request contains several different aspects of the package. It would be much better to have several pull requests that each contain one commit and only deals with one issue (and nothing else).

kmalhan commented 7 years ago

Thanks for the comments. I will divide the changes into several smaller pull request in next few days.

magazino / pylon_camera

Adding RGB8 Support #5