search

magazino / pylon_camera

ROS-Driver for Basler Cameras
BSD 3-Clause "New" or "Revised" License
78 stars 108 forks source link

Added Nodelet Support #8

Open kmalhan opened 7 years ago

kmalhan commented 7 years ago

This pull request added functionality to run as nodelet.

In order to run as nodelet, manual call of spin function with sleep is replaced by timer callback with separate node handle. Also, node handle is passed by main.cpp and no longer created in pylon_camera_node.cpp

This pull request is tested with Basler daA1600-60uc. Please review the changes and provide feedback.

tonybaltovski commented 7 years ago

+1

jonbinney commented 7 years ago

+1 !!!

I'm using this PR with a Basler Ace ACA1300-30GC GIGE on ROS kinetic, and it works great! It makes it relatively efficient to run the image_proc debayer nodelet to debayer color images. I'd also be for removing image rectification from the node itself, and launching the main image_proc nodelet.