magbicaleman / open-in-browser

Atom.io Package
MIT License
51 stars 37 forks source link

Code review #34

Closed ldez closed 7 years ago

ldez commented 8 years ago

Fix #28, #26, #25, #23, #21

ldez commented 8 years ago

Any remarks ?

magbicaleman commented 8 years ago

@ldez thank you for your contribution. I've only glanced it, but I'll be looking at it soon.

ldez commented 7 years ago

@magbicaleman now you can activate CI with Travis CI and AppVeyor Can you publish a new version ? (apm publish major)

magbicaleman commented 7 years ago

I have Travis CI activated (failed), not yet with AppVeyor. I'm assuming the AppVeyor CI, is to test out the plugin in the windows environment.