search

magbicaleman / open-in-browser

Atom.io Package
MIT License
51 stars 37 forks source link

just suddenly stopped working #45

Closed JaneCoder closed 7 years ago

JaneCoder commented 7 years ago

I'm on atom 1.17.0 x 64. This package has been great, but has suddenly just stopped working. I right click on an html file and select 'open in browser' and nothing happens. There is no error message or any feedback either. I updated all my packages, but this did not fix the issue.

jason-ruby commented 7 years ago

Same problem...verbatim.

magbicaleman commented 7 years ago

What OS are you guys on?

jason-ruby commented 7 years ago

macOS Sierra v10.12.4 (64-bit) Prior to open-in-browser (v0.5.0) ceasing to work I had not:

It very strangely just seemed to stop working and I cannot think of any outside influence that would have been the cause. I'm sure there is a reasonable cause and effect; just none that I can see.

Something that I had noticed several weeks ago is that in Atom, under settings, when I select Updates it generates the error Fetching outdated packages and themes failed. It is possible it could be related, however open-in-browser had been working without any noticeable issue several weeks even after I began seeing the update error.

JaneCoder commented 7 years ago

OS X El Capitan 10.11.6

My default browser is Firefox 53.0.2 (64-bit)

jacobbodkin commented 7 years ago

Same issue exactly.

OS Sierra 10.12.5, Atom 1.17.0

jason-ruby commented 7 years ago

My default browser is: Chrome v58.0.3029.110 (64-bit)

jacobbodkin commented 7 years ago

@BluePawDev what version of Atom are you running? I'm thinking it has to do with the new release

jason-ruby commented 7 years ago

1.17.0 (64-bit)

jason-ruby commented 7 years ago

BTW, I was able to clear the update issue I was having--doesn't seem to be related or have any impact either way.

TimBiden commented 7 years ago

Same scenario. Exactly. Just started today.

gtodd876 commented 7 years ago

I just installed this package and it does not work. Nothing happens after right click and select open in browser. Chrome is my default browser.

magbicaleman commented 7 years ago

Pushed out a new version, please let me know if this has resolved the issue

maccer83 commented 7 years ago

I also noticed this lately with 0.5.0. Just installed 0.5.1 but still nothing happens when I right-click on a file in the project tree and select "open in browser", or choose the command from the Packages menu for that matter.

EDIT: or... I kind of take it back. When I open the file and right-click somewhere in the text/editing area and chose "open in browser", it works. After I have done such a editing-area right-click once in any file after Atom has loaded, it works as expected also from the project file tree and also for other files. But after I restart Atom, I always have to do a editing-area right-click again.

MacOS Sierra 10.12.5 Atom 1.17.2 x64 (just updated from 1.17.0) Safari 10.1.1 System language: Swedish

objectkit commented 7 years ago

Unfortunately 0.5.1 didn't solve the problem. Same as above - with file already open, then clicking Open In Browser in right-click context menu, the package works. Right clicking on a file in tree-view, Open In Browser does nothing I'm afraid. macOS Sierra / Safari. Problem began after updating to Atom 1.17.0.

gtodd876 commented 7 years ago

It did not solve the problem for me.

I noticed my cursor will jump to the beginning of the file but that's the only behavior I notice when I run the command and it's the same for me whether I run the command in tree view, right click context menu on file or from the package menu.

jason-ruby commented 7 years ago

Same result as @maccer83: Right-click and selecting Open in Browser from the context menu in the project tree does not work, but a right-click and selecting Open in Browser from the context menu within the editing area works. I'll take that over nothing.

TimBiden commented 7 years ago

Same as @BluePawDev.

Nothing happens when CTRL-clicking in the tree view. CTRL-clicking in the editor of the open file that you want to run in the browser does work.

JaneCoder commented 7 years ago

Good catch, it is only not working with tree view. And shift-cmd-Q also works if you click on the file.

On Fri, May 26, 2017 at 10:58 AM, Tim Biden notifications@github.com wrote:

Same as @BluePawDev https://github.com/bluepawdev.

Nothing happens when CTRL-clicking in the tree view. CTRL-clicking in the editor of the open file that you want to run in the browser does work.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/magbicaleman/open-in-browser/issues/45#issuecomment-304305092, or mute the thread https://github.com/notifications/unsubscribe-auth/AC4yTzLv-af5cm5jc-9MulMiQuWEDah0ks5r9uh8gaJpZM4Nd-SY .

gtodd876 commented 7 years ago

screen shot 2017-05-26 at 2 55 44 pm screen shot 2017-05-26 at 2 55 53 pm

I just noticed that the key command to log out of my user account is the same as the default key command for open-in-browser. I was wondering if this has something to do with it. I tried looking in system preferences/keyboard/shortcuts to disable 'log out ("username")' but it's not listed there. I did an override of that global key command under Application Shortcuts create your own shortcut for Log Out ... So now that key command is different but it still does not work if I try to right click, open in browser. If I now use the key command shift+command+Q in atom it only moves my cursor to the beginning of the file.

magbicaleman commented 7 years ago

If you're experiencing open through the tree pane, are you using the default tree pane or another tree pane? For example are you using nuclide-file-tree

magbicaleman commented 7 years ago

Published a new patch 0.5.2 that should address the context menu "Open in Browser" issue.

maccer83 commented 7 years ago

Thanks, 0.5.2 seems to have solved the problem for me – right-clicking in the tree view works again! I use the standard tree pane.

gtodd876 commented 7 years ago

Yesterday I experienced some weird behavior. I tried using open-in-browser from the command palette and apple Xcode tried to start up. Now that I have updated to 0.5.2 that doesn't happen anymore but initiating command for open-in-browser just moves the focus to the editor window and places the cursor at 1,1. oib

jason-ruby commented 7 years ago

@magbicaleman: v0.5.2 look to have done the trick! Thank you! BTW, I was/am using the default Atom tree view. Thank you again for your work on the fix. I'm glad to have your package back and working again!

magbicaleman commented 7 years ago

@gtodd876 I'm going to close this issue, my apologies for the inconvenience but may you open a new issues with what you're experiencing. Also thank you very much for adding a gif video, that helps a lot for me.

gtodd876 commented 7 years ago

No problem, totally understand it's an issue specific specific to my system. I'll open a new issue.