magda-io / magda-minion-format

Magda Format Minion
Other
0 stars 0 forks source link

Consolidate GeoSpatial API / Service Format String #8

Closed t83714 closed 3 years ago

t83714 commented 3 years ago

Consolidate GeoSpatial API / Service Format String

Related ticket: #3 Related PR: https://github.com/magda-io/magda-minion-format/pull/4

Motivation

Proposed Solution

Information used to determine format string

All information available (unless we want to query the remote unknown API) is:

We will apply proposed logic on the information above in order to determine the actual format string

Format Detection Logic

Update July 2021

will now make both ESRI MapServer & ESRI Feature Server format as "ESRI MAPSERVER" due to here. Will create a seperate PR to terriajs and make ESRI FeatureServer show as "ESRI FeatureServer" after the PR is merged and deployed to NSW DT.

Update: release v1.0.0-rc.0 that mark ESRI Feature Server as ESRI MapServer for compatibility reason above. All future releases (i.e. v1.0.0-rc.1, v1.0.0), will all mark ESRI Feature Server as ESRI Feature Server correctly.

References & Links

t83714 commented 3 years ago

@mwu2018 When you have time, please have a look and let me know your thoughts on it (and whether can help to move away from the forked version)

mwu2018 commented 3 years ago

For datasets from magda registry, the v8 version of terriajs (branch next) looks for format aspect with patterns specified by formatRegex in https://github.com/TerriaJS/terriajs/blob/da49c023055435dc495d6392507c6f7c7cdd9754/lib/Models/MagdaReference.ts#L45 As long as Magda reports the format strings in those patterns, the terriajs will recognise them.

mwu2018 commented 3 years ago

MagdaCatelogueItem is replaced by MagdaReference in v8 terriajs.

mwu2018 commented 3 years ago

For SceneServer, look at https://github.com/TerriaJS/magda-minion-terria/blob/master/src/onRecordFound.ts

t83714 commented 3 years ago

closed via PR https://github.com/magda-io/magda-minion-format/pull/13