Broken link doesn't show correctly

magda-io / magda

A federated, open-source data catalog for all your big data and small data

https://magda.io

Apache License 2.0

498 stars 93 forks source link

Broken link doesn't show correctly #2004

Open aneesha09 opened 5 years ago

aneesha09 commented 5 years ago

Problem description

This dataset no longer works for download and leads to a "This website has closed page" Could we check why the broken link minion isn't catching it and fix it?

Problem reproduction steps

Got to - https://data.gov.au/dataset/ds-vic-26c325d0-5770-475a-8b7c-f3db70654986/distribution/dist-vic-ab8155fa-c4f7-47a7-b9dc-c9c17fb18d26/details?q=residential%20aged%20care%20providers

Click on "Download"

You will see this: human_services_victoria_redirection_page

Screenshot / Design / File reference

aneesha09 commented 5 years ago

This is another case - data is not publicly available and requires login. Shouldn't allow the "Download"? https://data.gov.au/dataset/ds-dga-3dab7c54-e4fe-43de-b89d-07a28fffa3c2/distribution/dist-dga-2600668a-7a6f-4cbb-ab9f-e8dd9c7f9cdd/details?q=%22residential%20aged%20care%22

AlexGilleran commented 5 years ago

They should return 404 or 400, but they're both returning 200, which is the code for "OK" :(.

The best we could really do short of reading the page and doing NLP is maybe noting where it's HTML but it should be a different format?

aneesha09 commented 5 years ago

noting where it's HTML but it should be a different format?

Yeah that would be useful and should suffice!