magda-io / magda

A federated, open-source data catalog for all your big data and small data
https://magda.io
Apache License 2.0
505 stars 92 forks source link

Make sure scala pods can be gracefully terminated within 15 seconds #3394

Closed t83714 closed 1 year ago

t83714 commented 2 years ago

Make sure scala pods can be gracefully terminated within 15 seconds

Previously, we introduced graceful termination logic for all our core repo pods. See #3380

For scala pods, it's done via Akka Coordinated Shutdown. Our implementation includes a 5s waiting period in case of any chunked response and 15s hardTerminationDeadline.

However, on GKE, the actual GracePeriod might be much shorter (down to 15s). See this comment.

We should adjust the settings of Coordinated Shutdown i.e.:

to make sure the termination can be completed within 15s.

Those parameters should also be configurable via Helm charts

t83714 commented 1 year ago

closed via https://github.com/magda-io/magda/pull/3409