magda-io / magda

A federated, open-source data catalog for all your big data and small data
https://magda.io
Apache License 2.0
493 stars 93 forks source link

Deprecated annotation `kubernetes.io/ingress.class` notice for ingress chart #3523

Open t83714 opened 1 month ago

t83714 commented 1 month ago

Deprecated annotation kubernetes.io/ingress.class notice for ingress chart

https://kubernetes.io/blog/2020/04/02/improvements-to-the-ingress-api-in-kubernetes-1.18/

Deprecating the Ingress Class Annotation Before the IngressClass resource was added in Kubernetes 1.18, a similar concept of Ingress class was often specified with a kubernetes.io/ingress.class annotation on the Ingress. Although this annotation was never formally defined, it was widely supported by Ingress controllers, and should now be considered formally deprecated.

https://cloud.google.com/kubernetes-engine/docs/concepts/ingress#controller_summary

CleanShot 2024-05-14 at 14 59 08@2x

Although the kubernetes.io/ingress.class annotation is deprecated in Kubernetes, GKE continues to use this annotation. You cannot use the ingressClassName field to specify a GKE Ingress. You must use the kubernetes.io/ingress.class annotation.

Technical notes

The warning message won't cause any functionality issues. But when we want to remove it, we will need a solution to accommodate both GKE ingress and third-party ingress.