search

magdesign / PocketVJ-CP-v3

PocketVJ 3.x Control Panel
https://www.pocketvj.com
Other
156 stars 33 forks source link

clean up repetitions & files duplicates #83

Closed b3bb0 closed 3 years ago

b3bb0 commented 5 years ago

There were a bit of repetitions all over... I cleanup a bit, just easier to work on and debug... I also sent you an email, let me know what you think

cheers

magdesign commented 5 years ago

Thanks for this great fix. But I can not merge since it would break the OSC compatibility: https://github.com/magdesign/PocketVJ-CP-v3/blob/master/sync/osc_control.js

b3bb0 commented 5 years ago

support for node, sorry I missed it before

b3bb0 commented 5 years ago

fixed! sorry... I forgot the node part

On Mon, 27 May 2019 at 05:45, magdesign notifications@github.com wrote:

Thanks for this great fix. But I can not merge since it would break the OSC compatibility: https://github.com/magdesign/PocketVJ-CP-v3/blob/master/sync/osc_control.js

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/magdesign/PocketVJ-CP-v3/pull/83?email_source=notifications&email_token=AAJDZK7AJYGSADPYECHSFGDPXLSG7A5CNFSM4HOZHJT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWIMEXA#issuecomment-496026204, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJDZK2VFZC73TW6IWIXPETPXLSG7ANCNFSM4HOZHJTQ .

magdesign commented 5 years ago

Thanks for this! Sorry that it takes so long to test and merge your commit, I saw that you changed index.html to index.php and I need to figured out how integrate this all into my pipeline. e.g. update command would now leave the index.html on the server and index.php would be put aside... all this little things must be taken care of so the users don't break their installation.... :-)

b3bb0 commented 5 years ago

No worries, I'm also got very busy lately... as soon I'm able to breath a bit more I'll touch base and see how I can properly help :)

On Wed, 5 Jun 2019 at 19:32, magdesign notifications@github.com wrote:

Thanks for this! Sorry that it takes so long to test and merge your commit, I saw that you changed index.html to index.php and I need to figured out how integrate this all into my pipeline. e.g. update command would now leave the index.html on the server and index.php would be put aside... all this little things must be taken care of so the users don't break their installation.... :-)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/magdesign/PocketVJ-CP-v3/pull/83?email_source=notifications&email_token=AAJDZKY4NKSKA5YN7HDE4CDPY6B3LA5CNFSM4HOZHJT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW7EZ3Y#issuecomment-499010799, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJDZKZAZMTODX6GC3S537TPY6B3LANCNFSM4HOZHJTQ .