search

magdimahmed / MySimpleTweets

0 stars 0 forks source link

[Android Bootcamp] week #4 - Please Review my Twitter app version 2 #2

Open magdimahmed opened 9 years ago

magdimahmed commented 9 years ago

My app twitter client version 2 ready for your review I have added some of the optional features , /cc @codepathreview @codepath Thanks ~Magdi I created branch called version2

codepathreview commented 9 years ago

:+1: Project looks good. Good job working on making the UI better. I guess all the classes(specially for fragments) were not pushed to the repo, so I could not do full code review. The main thing to keep in mind for this assignment was to abstract out as much functionality you can in parent fragment.

I have provided a detailed Project 4 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully you can see this coming together as a "fully fledged" twitter client with some more work and polish. This app contains all of the components now (fragments, models, networking, client, tab navigation, image loading, et al) of 90% of dynamic data-driven API client. Obviously there are lots of details and patterns to learn, but by this point you have been introduced to all the major frameworks and concepts. Hopefully you would feel fairly confident getting started making Android apps for instagram, pinterest, yardsale, flickr, using the same patterns.