search

mage-os-lab / web-installer

4 stars 4 forks source link

chore: remove unmodified core files from web-installer #2

Open rhoerr opened 3 days ago

rhoerr commented 3 days ago

A lot of the module files appear in core (https://github.com/mage-os/mageos-magento2/tree/2.4-develop/setup) with no differences or only minor differences (with core seeming newer than the versions here). I ran a diff between the core setup folder and this and stripped out almost all of them.

Hopefully this isn't a problem for development of this module. It seems best to avoid code duplication though, and code that does exist in core may have important changes (security or otherwise) from upstream.

jakwinkler commented 3 days ago

Will have to review that one, Setup module contains fixtures to generated via CLI so not sure if all these files should be removed.