Integration tests workflow improvements - Githubissues

mage-os / github-actions

Mage-OS GitHub Actions for the distribution repositories.

13 stars 12 forks source link

Integration tests workflow improvements #218

Closed ihor-sviziev closed 10 months ago

ihor-sviziev commented 10 months ago

PR Checklist

Please check if your PR fulfills the following requirements:

[ ] The commit message follows our guidelines: https://github.com/mage-os/github-actions/blob/main/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: Failed the TestModuleOverrideConfig module integration tests.

Magento uses a custom Suite loader, Magento Integration Tests. This custom suite loader isn't getting automatically executed, so in Magento was created a special file that manages custom tests skipping mechanism: https://github.com/magento/magento2/blob/01f8d7ff759ca1f864b06daae16f5ae54aa3d001/dev/tests/integration/testsuite/Magento/IntegrationTest.php#L39-L59

This is sub-task of https://github.com/mage-os/mageos-magento2/pull/61

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

vpodorozh commented 10 months ago

Hello @Vinai - can we merge this one? It's going to fix override.xml failed integration tests and would actually make it closer to the way how integration tests are executed by Magento.

Thank you.

test run: https://github.com/vpodorozh/mageos-magento2/actions/runs/7655377705