mage-os / mageos-magento2

Work in progress.
Open Software License 3.0
213 stars 45 forks source link

MageOS version #108

Open pjw345 opened 1 month ago

pjw345 commented 1 month ago

Summary

After migrating to Mage OS 1.0.4 3rd party modules that rely on release version failed as they are checking against Magento release version and then selecting the wrong code version. An example is Mirasvit's Ultimate Search module that checks which Magento version is installed, to then build the correct Class headers, src/SearchElastic/SearchAdapter/Query/Builder/MatchCompatibility.php

as 1.0.4 < 2.4.4 it is selecting the wrong Class headers and the compilation fails.

Do you propose a better was of selecting which version is installed?

Examples

if (version_compare(CompatibilityService::getVersion(), '2.4.4', '<')) {

Proposed solution

No response

Release note

No response

Triage and priority