search

mage-os / mageos-magento2

Work in progress.
Open Software License 3.0
214 stars 45 forks source link

Issue #5 GitHub Action Semantic Checker #11

Closed lefte closed 1 year ago

lefte commented 2 years ago

GitHub Action Semantic Checker

Creates a GitHub Action to run the Semantic Version Checker against the head and base branches

Fixed Issues

Addresses issue mage-os/mageos-magento2#5

lefte commented 2 years ago

Working on repairing the forked repository variable on the broken step

lefte commented 2 years ago

Okay, thanks for your patience, action https://github.com/mage-os/mageos-magento2/actions/runs/3374600139 should now work with forked repositories.

lefte commented 2 years ago

Is this workflow only relevant for the mageos-magento2 repository? I assume it will also be useful for the other mageos-* repos. Because of this, I suggest making it a reusable workflow inside of https://github.com/mage-os/infrastructure, kind of like merge-upstream-changes.yml. This helps with maintenance

Yeah, I can start work on refactoring this to be a standalone action. Didn't think about using it for other repositories, although I think in theory we can just copy this file to other repos.. I'll find out.

lefte commented 2 years ago

Is this workflow only relevant for the mageos-magento2 repository? I assume it will also be useful for the other mageos-* repos. Because of this, I suggest making it a reusable workflow inside of https://github.com/mage-os/infrastructure, kind of like merge-upstream-changes.yml. This helps with maintenance

Yeah, I can start work on refactoring this to be a standalone action. Didn't think about using it for other repositories, although I think in theory we can just copy this file to other repos.. I'll find out.

Now refactored to reuse an action, although it has to be merged to the infrastructure repository before I can change it here

lefte commented 1 year ago

(Waiting on https://github.com/mage-os/infrastructure/pull/24 )