mage-os / mageos-magento2

Work in progress.
Open Software License 3.0
214 stars 45 forks source link

Phpcs Baseline testing #24

Closed MeetKamal closed 1 year ago

MeetKamal commented 1 year ago

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

MeetKamal commented 1 year ago

Hi @sprankhub , Please verify the comments

MeetKamal commented 1 year ago

Hi Simon

Better to have a call and discuss those issues.
For the coding-standard folder, I also agree that we shouldn't have that for CI integration. But when am trying to remove not getting the required output.

Can we review it after today's call ? if possible.

MeetKamal commented 1 year ago

Hi @sprankhub

We are getting below error when using report-file parameter in phpcs

Run php vendor/bin/phpcs --standard=Magento2 \ php vendor/bin/phpcs --standard=Magento2 \ --report=\DR\CodeSnifferBaseline\Reports\Baseline --report-file=/home/runner/work/mageos-magento2/mageos-magento2/phpcs.baseline.xml --file-list=/home/runner/work/mageos-magento2/mageos-magento2/phpcs_files.txt cat /home/runner/work/mageos-magento2/mageos-magento2/phpcs.baseline.xml shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0} env: COMPOSER_PROCESS_TIMEOUT: 0 COMPOSER_NO_INTERACTION: 1 COMPOSER_NO_AUDIT: 1 Time: 159ms; Memory: 16MB

Error: Process completed with exit code 1.

Please review below action work flow https://github.com/MeetKamal/mageos-magento2/actions/runs/5057528172/jobs/9076402262