Integration tests/ fix failed tests

[vpodorozh]

Description (*)

Pull Request must contain fixes and changes to failed/error integration tests and/or functionality they cover.

Related Pull Requests

• https://github.com/mage-os/mageos-magento-zend-db/pull/1
• https://github.com/mage-os/github-actions/pull/217

Current state:

tests total: 13311 failing: 37 ( https://github.com/vpodorozh/mageos-magento2/actions/runs/7476706132 ) tests in unclear status: ~0

Integration Tests Execution results on various Magento versions:

https://docs.google.com/spreadsheets/d/1bGJZ1PBY6HS4hyhJyWVX0SnEOcbESnew40Myo2Bkmn4/edit?usp=sharing

Issues to be Solved/Fixed:

• [x] Fix \Magento\Paypal\Model\Express\CheckoutTest - dbIsolation missing
• [x] Fix tests Magento\CatalogImportExport\Model\Import\ProductTest\Produc…
• [x] Fix failing tests with error undefined key 'product_id' from app/co…
• [x] Fix failed tests: \Magento\Wishlist\Controller\Index\AddTest
• [x] Checkout :ref - fixed by @novikor
• [ ] GraphQl :ref - WIP by @novikor
• [x] Customer :ref - fixed by @ihor-sviziev ( https://github.com/vpodorozh/mageos-magento2/pull/8 )
• [x] ConfigurableProduct :ref - fixed by @novikor and @vpodorozh
• [ ] TestModuleOverrideConfig :ref
• [x] Wishlist :ref - fixed by @novikor
• [ ] PRIO Catalog
  • [x] :ref - fixed by @vpodorozh (we need to split up tests - rabbitmq can not keep up)
  • [ ] : ref
• [x] Framework :ref Fixes ref:
  • f3136c98dde2e3368c1852ae9cd0eca5b98dfd23
  • 8d290652603c6df989cdf6da37e08732539545ae
  • ba1b15365dc37a9e8db35d1b1f26d5146f041aef
  • c9da6b7d7be30181dc9db6118efbe7ff42b316cc
• [ ] Bundle
  • [ ] :ref
  • [ ] :ref
• [x] Version :ref - fixed by @ihor-sviziev
• [x] PRIO Sales :ref - fixed by @novikor and @vpodorozh
• [x] CatalogWidget :ref - fixed by @novikor
• [ ] CatalogInventory
  • [x] :ref - fixed by @vpodorozh
  • [ ] :ref
• [ ] Security :ref - WIP by @vpodorozh

Contribution

1. Pick up point that is not solved yet and you wanna work on
2. Solve it and create PR into vpodorozh:integration-tests/fix-tests (this PR branch)
3. Ping me in Mage-OS Discord and I'll review your PR asap. my discord vladyslavpodorozhnyi

[ihor-sviziev]

just checked TestModuleOverrideConfig failure https://github.com/vpodorozh/mageos-magento2/actions/runs/7476706132/job/20347768985#step:6:60

It looks like it was added in eceb5d9c, and it depends on some overrides.xml file, that isn't triggered when running tests from specific folder. Do anyone know what is the overrides.xml file designed for and how to integrate it properly?

Might be related https://github.com/extdn/github-actions-m2/issues/56, @damienwebdev maybe you know something about it?

[ihor-sviziev]

Hi @vpodorozh, Could you pls try re-running tests on the latest version? I noticed that some failures aren't reproducing on the 2.4-develop branch, e.g. I suggest reverting some of my changes https://github.com/vpodorozh/mageos-magento2/pull/9.

[vpodorozh]

Hi @vpodorozh, Could you pls try re-running tests on the latest version? I noticed that some failures aren't reproducing on the 2.4-develop branch, e.g. I suggest reverting some of my changes vpodorozh#9.

Actually only one thing was fixed in latest 2.4-develop - related to spaces in page generation.
Just merged your revert.

And Magento have added a one more new bug - https://github.com/vpodorozh/mageos-magento2/actions/runs/7596143665/job/20689518571#step:6:34

For detailed test results on various Magento versions (Mage-OS, Magento + latest updated) - lookup here: https://docs.google.com/spreadsheets/d/1bGJZ1PBY6HS4hyhJyWVX0SnEOcbESnew40Myo2Bkmn4/edit?usp=sharing

[vpodorozh]

Could you please change those two small things I commented on?

UPDATE: both comments resolved

Great @Vinai . I;ve also double-checked the fix from zend-db - works fine.
So we can merge this PR.