mage-os / mageos-magento2

Work in progress.
Open Software License 3.0
213 stars 45 forks source link

VCL_recv rework based on closed Magento 2 PR #62

Open toonvd opened 11 months ago

toonvd commented 11 months ago

Description

This PR is a rework of the Magento VCL (the vcl_recv part) PR found here: https://github.com/magento/magento2/pull/36796/files

I left out 2 controversial changes:

PRs for other subroutines will follow (probably weekly)

All credits go to @peterjaap and @ThijsFeryn, I am simpling slicing this up and removing controversial parts to get early approval.

Related Pull Requests

https://github.com/magento/magento2/pull/36796/files

Manual testing scenarios

Contribution checklist (*)

peterjaap commented 11 months ago

Thanks @toonvd, it's still on my todo list to make that Magento PR better, but time & priorities, so I'm excited to see you picking this up for MageOS! :)

ThijsFeryn commented 11 months ago

Looks good to me, thanks for the effort @toonvd