mage-os / mageos-magento2

Work in progress.
Open Software License 3.0
208 stars 41 forks source link

Nx Integration Workflow not waiting for called workflow to complete #74

Open adamzero1 opened 9 months ago

adamzero1 commented 9 months ago

Description (*)

When a PR is submited, this repo calls a workflow in the actions repo. The workflow in this repo does not wait for the called repo to complete. image Here we can see "Calling Nx Integration Tests" doesn't care about the results of the tests ran from the matrix.

Related Pull Requests

https://github.com/mage-os/mageos-magento2/actions/runs/7101858336?pr=68

Fixed Issues (if relevant)

With this in place we should see the following (please note these screenshot were taken from another repo as I can't mimic how this will work until this is in the default branch)

If the matrix jobs complete successfully image

If the matrix jobs fail (i.e integration tests fail) image

Manual testing scenarios (*)

N/A

Questions or comments

Contribution checklist (*)