mage / mage-sdk-unity

MAGE client SDK for Unity
MIT License
2 stars 13 forks source link

Feature/cleanup #37

Closed kefniark closed 8 years ago

kefniark commented 8 years ago

Description

Few open issues are probably concerned by this PR https://github.com/mage/mage-sdk-unity/issues/5 https://github.com/mage/mage-sdk-unity/issues/7 https://github.com/mage/mage-sdk-unity/issues/14 https://github.com/mage/mage-sdk-unity/issues/18 https://github.com/mage/mage-sdk-unity/issues/19

P.S. This PR move and rename lot of method, updating from a previous version is not smooth and need some modules modifications

TODO Later

MiLk commented 8 years ago

It would be a good idea to start doing release and creating tags on this project. It would avoid breaking projects when the API changes.

nullorvoid commented 8 years ago

At the moment it looks like this is a per project branch structure, but at some point we should start tagging and releasing them I agree. @ronkorving @AlmirKadric do we have a path to go down to start doing this?

ronkorving commented 8 years ago

What do you mean by "a path"? Just tag em and bag em :) Anyone willing to take responsible ownership can be a release manager.

christopherobin commented 8 years ago

You'll want to port the latest changes made by @AlmirKadric in his PR #35 especially the bits about headers and cookies

kefniark commented 8 years ago

Yes, we are planning with @nullorvoid to rewrite this network part and make it testable. So I will backport the last PRs at that time (ipv6, header, cookies,...)

nullorvoid commented 8 years ago

I'm ok with merging this PR to get things moving (it's not against develop) @AlmirKadric @ronkorving