mage / mage-sdk-unity

MAGE client SDK for Unity

MIT License

2 stars 13 forks source link

Fix Tome's root property #55

Closed kefniark closed 8 years ago

kefniark commented 8 years ago

Description

I finally found why the event was not properly propagated to the top level container (JArray) Related to a small error due to the fact that a private property and a parameter have the same name ...

The only other function where this trouble can also happen is ApplyOperation but it seems fine to me. If someone else can just double check it to be sure.

Seriously, if we plan to keep this tome implementation, we really need unit tests.

nullorvoid commented 8 years ago

LGTM

nullorvoid commented 8 years ago

On the second point I think that should be root not this.root. @AlmirKadric can confirm tomorrow, for the moment I will merge this.