search

mage / mage-sdk-unity

MAGE client SDK for Unity
MIT License
2 stars 13 forks source link

Update binding flags, and pick the correct httprequest class #62

Closed Tatsujinichi closed 7 years ago

Tatsujinichi commented 7 years ago

For Issue BindingFlags and Invoke Member Unity 2017.1 #61

not tested on earlier versions of unity, works on 2017.1.0f3

Tatsujinichi commented 7 years ago

@nullorvoid can you review this

nullorvoid commented 7 years ago

Logic looks fine, no problem with this, but it will need to be tested on 5.5.3 before I will merge it. Would you mind doing this? I can do this, but at the earliest will be Tuesday next week

AlmirKadric commented 7 years ago

@Tatsujinichi why some of the lines showing as changed although they're not Line endings?

Other than above comments LGMT 👍

Tatsujinichi commented 7 years ago

I assume my editor was converting spaces to tabs, but I could be wrong.

AlmirKadric commented 7 years ago

@Tatsujinichi Both lines in the diff have tabs, its why i'm assuming line endings. Not really a big deal, more a nuisance and it could even be the line endings are wrong in the original code. If you could just check what it is so we know

Tatsujinichi commented 7 years ago

Yes, it was line endings. Before: CRFL ( 0D 0A ) before After: LF ( 0A ) after

I believe the LF is the correct ending.

AlmirKadric commented 7 years ago

👍

Tatsujinichi commented 7 years ago

Actually I am not sure the unity version of httprequest is working at all. I've switched back to the .net version.

nullorvoid commented 7 years ago

We should probably move it from WWW to UnityWebRequest which is much newer and probably better supported.

Tatsujinichi commented 7 years ago

closing this as https://github.com/mage/mage-sdk-unity/pull/66 should accomplish the same thing