mage2tv / magento-cache-clean

A faster drop in replacement for bin/magento cache:clean with file watcher
BSD 3-Clause "New" or "Revised" License
531 stars 63 forks source link

1.0.48 forgot to build? #104

Closed riconeitzel closed 2 years ago

riconeitzel commented 2 years ago

Hey Vinai,

just noticed:

composer2 require --dev mage2tv/magento-cache-clean
Info from https://repo.packagist.org: #StandWithUkraine
Using version ^1.0 for mage2tv/magento-cache-clean
./composer.json has been updated
Running composer update mage2tv/magento-cache-clean
Gathering patches for root package.
Loading composer repositories with package information
Info from https://repo.packagist.org: #StandWithUkraine
In Laminas\DependencyPlugin\DependencyRewriterV2::onPrePoolCreate
Updating dependencies
Lock file operations: 0 installs, 1 update, 0 removals
  - Upgrading mage2tv/magento-cache-clean (1.0.47 => 1.0.48)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 1 update, 0 removals
  - Downloading mage2tv/magento-cache-clean (1.0.48)
Gathering patches for root package.
Gathering patches for dependencies. This might take a minute.
  - Upgrading mage2tv/magento-cache-clean (1.0.47 => 1.0.48): Extracting archive
Package container-interop/container-interop is abandoned, you should avoid using it. Use psr/container instead.
Package laminas/laminas-console is abandoned, you should avoid using it. Use laminas/laminas-cli instead.
Package phpunit/php-token-stream is abandoned, you should avoid using it. No replacement was suggested.
Package sebastian/finder-facade is abandoned, you should avoid using it. No replacement was suggested.
Generating autoload files
1 package you are using is looking for funding.
Use the `composer fund` command to find out more!

BUT:

vendor/bin/cache-clean.js -w
Release 1.0.47 #StandWithUkraine

it still shows 1.0.47?

Vinai commented 2 years ago

Heh, this time I git push --tags before git push. Seems like packagist.org picked up the tag before I updated the source. If you pull in 1.0.48 again the output will have changed: https://github.com/mage2tv/magento-cache-clean/blob/1.0.48/src/cache/core.cljs#L10

I'll let that be a lesson not to mess up the order of operations again :)