Add app/i18n directory to watcher list

mage2tv / magento-cache-clean

A faster drop in replacement for bin/magento cache:clean with file watcher

BSD 3-Clause "New" or "Revised" License

528 stars 61 forks source link

Add app/i18n directory to watcher list #64

Closed Vinai closed 4 years ago

Vinai commented 4 years ago

Any csv file changes should trigger translation and full_page cache cleaning, as well as removing generated static js-translation.json files.

Thanks to @seyuf for reporting!

Vinai commented 4 years ago

Implemented in upcoming 1.0.18 release.

seyuf commented 4 years ago

@Vinai can you let this open? I ll let you know if good for closing after some testing.

Vinai commented 4 years ago

Sure

seyuf commented 4 years ago

@Vinai the fix is not working when the i18n dir is symlinked (i.e ln -s /external-git-dir/app/i18n /var/www/{{magento_base_dir}}/app/i18n). I guess the same behaviour will be observed, if subdirs of i18n are symlinked. PS: it is working fine with basic setup though.

Vinai commented 4 years ago

Thanks for the update. I'll see if I can make it work with symlinks, too.

Vinai commented 4 years ago

I've released 1.0.20 that also works with a symlink app/i18n folder.

seyuf commented 4 years ago

@Vinai tested everything ok. Good for closing. Thanks.