search

mage2tv / magento-cache-clean

A faster drop in replacement for bin/magento cache:clean with file watcher
BSD 3-Clause "New" or "Revised" License
527 stars 61 forks source link

Cache cleaner detects file change, but GUI is unchanged? #67

Closed swaibar closed 4 years ago

swaibar commented 4 years ago

image

I have made a change to vendor\magento\module-checkout\view\frontend\templates\cart\noItems.phtml (just as a test I am not advocating hacking the core) and although it appears to be picked up by the cache cleaner, when I reload the page my change isn't shown... what am I doing wrong please?

Vinai commented 4 years ago

Since Magento 2.1 there is a bug that causes the full page cache records to be written to the var/cache directory instead of var/page_cache.
The bug is only "active" if the default Magento cache configuration is used. The issue the bug causes is that the cache cleaner sometimes seem to not work (e.g. the full page cache is not cleaned, even though it says it is).

There is an easy workaround, namely removing all cache configuration from the default app/etc/env.php.
The bug only affects the default config with the file system cache backend. Redis or Varnish are not affected. The bug will be fixed in the (currently upcoming) Magento 2.3.4 release.

Possibly you are running into this bug? Please post the cache section of your app/etc/env.php and your Magento version to confirm if this is it.

Vinai commented 4 years ago

See https://github.com/mage2tv/magento-cache-clean/issues/48#issuecomment-571497164 for another case where that happened. Maybe I should add automatic detection of affected Magento versions...

Vinai commented 4 years ago

Closing since no feedback from original author of the post, and since then I've implemented automatic detection of the bug, too.