search

magefan / module-blog

Magento 2 Blog Extension is a solution that helps you to create a blog on Magento and manage posts,categories, tags, authors, and comments.
https://magefan.com/magento2-blog-extension
Other
263 stars 135 forks source link

Translation to Hebrew #152

Closed eladnm closed 6 years ago

eladnm commented 6 years ago

Hi,

Thanks for this great module. I am preparing an Hebrew translation by creating he_HE.csv file and i wanted to know how to apply the translation to the blog.

i need to put it in the i18n folder and than?

magefan commented 6 years ago

Hello @eladnm you need to place it into i18n in the blog folder https://github.com/magefan/module-blog/tree/master/i18n and then flush magento cache.

Could you please send us he_HE.csv file via email support@magefan.com and we will add it to the module repository, so it can be included in the next release automatically?

eladnm commented 6 years ago

Sure, I will email you the file when I am done. how will magento will know to take the he_HE.csv file and apply it to the blog? i dont need to config anything and direct to the he_HE.csv file?

magefan commented 6 years ago

Magento takes a look at the locale settings in the admin panel. Then find all language_Language.csv files in extensions, themes, language packages and merge them.

eladnm commented 6 years ago

so i have to run? php bin/magento setup:di:compile php bin/magento setup:static-content:deploy

magefan commented 6 years ago

no,

  1. Make sure that in Stores > Configuration he_HE has been set as locale
  2. add file to app/code/Magefan/Blog/i18n/he_HE.csv or vendor/magefan/module-blog/i18n/he_HE.csv
  3. run php bin/magento cache:clean
eladnm commented 6 years ago

Doesn't seem to work. For example I translated the word recent post but it's still in English. https://www.deals4u.co.il/blog

magefan commented 6 years ago

Could you please send the .csv file to us, and we will check. As the suggestion, the issue can be in the theme templates.

eladnm commented 6 years ago

issue fixed, the file should be he_IL.csv. I will email it to you when i am done translating all the words.

magefan commented 6 years ago

@eladnm , is everything OK or you have some issues with he_IL? Could we ask you please to share the he_IL.csv file so we can include it in the next release?

eladnm commented 6 years ago

Hi @magefan, I will email it to you later today. I completed the translation of the important words but not all words.