search

magefan / module-blog

Magento 2 Blog Extension is a solution that helps you to create a blog on Magento and manage posts,categories, tags, authors, and comments.
https://magefan.com/magento2-blog-extension
Other
265 stars 136 forks source link

Syntax error in the file view/frontend/templates/lazyload-js.phtml #594

Closed MaximeChamont closed 3 months ago

MaximeChamont commented 3 months ago

Describe the bug

SyntaxError: Unexpected token '}'

coming from your last rework of the file https://github.com/magefan/module-blog/commit/c5c322e687d4757031c7a80a5c7cade3e6d93313#diff-47fdd2b43655ce435d81e63fb812096f0b7073e6547ea3d55dc64708a2c6df2f

Preconditions:

To Reproduce Steps to reproduce the behavior:

  1. Go to the blog homepage
  2. Open the browser console
  3. See the error
magefan commented 3 months ago

@MaximeChamont , thank you for your report. Please use this fix https://github.com/magefan/module-blog/commit/64d350c3a84d1cd187756e441ce1566ae58af6bf Once allied don't forget to redeploy static content. Please let us know if this works for you.

MaximeChamont commented 3 months ago

Thanks for your return but your fix is incorrect. It is not an issue with a missing semicolon but it is due to an additional bracket here: https://github.com/magefan/module-blog/commit/c5c322e687d4757031c7a80a5c7cade3e6d93313#diff-47fdd2b43655ce435d81e63fb812096f0b7073e6547ea3d55dc64708a2c6df2fR52

magefan commented 3 months ago

@MaximeChamont , yes, you completely right, here is the change https://github.com/magefan/module-blog/commit/ef5e8d06c5647582ba4edfb11aecffa539b729d5

MaximeChamont commented 3 months ago

It works fine now, thanks !