magefan / module-community

This module is required for other Magefan extensions for Magento 2
Other
26 stars 13 forks source link

Case Sensitivity Problem with "view" Directory #31

Closed ElTeteDBit closed 4 months ago

ElTeteDBit commented 4 months ago

Description

I am experiencing an issue with a Magento 2 module where the directory name "view" needs to be capitalized as "View". Failing to do so results in the following error:

Error: Class "Magefan\Community\View\Helper\SecureHtmlRenderer" not found in /var/www/source/scootfast-magento/generated/code/Magefan/Community/View/Helper/SecureHtmlRenderer/Proxy.php:7

Steps to Reproduce

Use the module with the directory named "view". Attempt to load a page or functionality that utilizes the module.

Expected Result

The module should function correctly without case sensitivity issues.

Actual Result An error is generated indicating that the class "Magefan\Community\View\Helper\SecureHtmlRenderer" cannot be found.

Additional Information

Magento 2 version: 2.4.6-p5 Module version: 2.6.2 Renaming the "view" directory to "View" resolves the issue. This appears to be a case sensitivity problem that may affect other environments as well.

Proposed Solution

Please update the module to ensure the directory is correctly named "View" to avoid case sensitivity issues.

Thank you for your attention to this matter.

magefan commented 4 months ago

@ElTeteDBit , could you please provide some details about your environment? What is your Magento, PHP version, what OS do you use? Is your OS filesystem case-sensitive?

If you check this file https://github.com/magefan/module-community/blob/master/View/Helper/SecureHtmlRenderer.php it is inside View (V capital) folder, and the namespace is Magefan\Community\View\Helper with capital V as well.

ElTeteDBit commented 4 months ago

@magefan Here are the details about my environment:

I apologize for the confusion. The problem is actually in the Google Tag Manager module. If I rename the folder to View everything is working as expected

image
magefan commented 4 months ago

@ElTeteDBit , please don't delete the view folder in the google tag manager extension, it's the wrong solution.

Could you please try this fix https://github.com/magefan/module-community/pull/32/files ? Don`t forget to run bin/magento setup:di:compile command after you apply changes.

Let us know if it helps

ElTeteDBit commented 4 months ago

@ElTeteDBit , please don't delete the view folder in the google tag manager extension, it's the wrong solution.

Could you please try this fix https://github.com/magefan/module-community/pull/32/files ? Don`t forget to run bin/magento setup:di:compile command after you apply changes.

Let us know if it helps

Yes, it is working right now applying these changes. Thank you 👍 .

Are you going to push this to the master branch?

magefan commented 4 months ago

@ElTeteDBit , just released a new version 2.1.28