search

magefan / module-lazyload

https://magefan.com/magento-2-image-lazy-load-extension
Other
53 stars 16 forks source link

No space between attributes #5

Closed simonrl closed 5 years ago

simonrl commented 5 years ago

Error thrown on validator.w3.org and caused in Magefan\LazyLoad\Plugin\BlockPlugin, L80-81:

"data-original" gets added directly after the src attribute, resulting in no space between the two IMG attributes.

Expected: <img src="..." data-original="..." />

Actual result: <img src="..."data-original="..." />

(note the missing space)

Would you release a new version if I create a PR? We're using the module via composer, so it would be nice to have that fix in the code.

Thanks Simon

magefan commented 5 years ago

@simonrl , thank you for your report. PR request will be greate. Tnx.

magefan commented 5 years ago

Hello @simonrl , did you have a chance to create a PR, if you have a fix you can simply send it to support@magefan.com we will review it and add to the repo.

simonrl commented 5 years ago

Hey, sorry, completely forgot that. See here pls: https://github.com/magefan/module-lazyload/pull/8