search

magefile / mage-action

GitHub Action for Mage
https://github.com/marketplace/actions/mage-action
MIT License
33 stars 7 forks source link

change api to use github REST api #268

Closed sheimi closed 1 year ago

crazy-max commented 1 year ago

@sheimi I will switch to the Octokit client to see how it goes

sheimi commented 1 year ago

Looks like release name is different. Octokit make sense. the api is rate limited without token.

sheimi commented 1 year ago

but with Octokit, GITHUB_TOKEN is required. https://github.com/octokit/auth-action.js#createactionauth . Hope Github will revert their release soon.

crazy-max commented 1 year ago

but with Octokit, GITHUB_TOKEN is required. https://github.com/octokit/auth-action.js#createactionauth . Hope Github will revert their release soon.

api.github.com is rate limited so we need a token anyway :disappointed: (can be automatically injected without changes in your workflow)

I'm addressing the changes in #269 but thanks for your contrib!

sheimi commented 1 year ago

Thanks for the fixes.