search

magefile / mage

a Make/rake-like dev tool using Go
https://magefile.org
Apache License 2.0
4.01k stars 250 forks source link

magefile generated init should use best practices #408

Open johannes-gehrs opened 2 years ago

johannes-gehrs commented 2 years ago

Not sure if it's literally a bug but it seems weird to me that the magefile you generate with init does not use the built-in libraries like sh but instead they use standard library functions, e.g.

    cmd := exec.Command("go", "build", "-o", "MyApp", ".")

I could also make a PR for that but I wanted to check first whether it is intentional.

natefinch commented 2 years ago

This is a good point. I don't really know why they're written without using sh :)

Please feel free to update it :)

jespino commented 1 year ago

I going to prepare a PR for this.

natefinch commented 1 year ago

Yeah, I think this is a good idea, thanks.

On Thu, Jul 28, 2022, 1:55 PM Jesús Espino @.***> wrote:

I going to prepare a PR for this.

— Reply to this email directly, view it on GitHub https://github.com/magefile/mage/issues/408#issuecomment-1198458638, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAYJZSEBWAN4IJBOVHLCKLDVWLCRNANCNFSM5PKR6DZA . You are receiving this because you commented.Message ID: @.***>