feat: support trailing line comment for mage:import

magefile / mage

a Make/rake-like dev tool using Go

https://magefile.org

Apache License 2.0

4.01k stars 250 forks source link

feat: support trailing line comment for mage:import #480

Closed anuraaga closed 9 months ago

anuraaga commented 9 months ago

Currently, //mage:import is only read from leading doc comments for an import statement, not trailing line comments. This makes it incompatible with tools like gosimports. It seems reasonable to support line comments too and is luckily not difficult

anuraaga commented 9 months ago

@natefinch or anyone wondering if you'll get a chance to review this PR? I noticed many PRs haven't had any comments for some months so perhaps this project is unmaintained now - it happens, but hoping to be able to confirm it. Thanks.

anuraaga commented 9 months ago

Thanks a lot @natefinch! Just wondering if there's anything left to do to merge. Cheers

natefinch commented 9 months ago

Nope! I guess I forgot to hit the button:)