Refactor: many sets contains wrong block and parent set info

[JayDi85]

Some sets contains wrong info about block (~134) and parent set info (~358). It's not a critical, but must be fixed someday. Block info used to group sets in the GUI choose dialog. Parent set info used to generate a booster.

Search that code to enable verify test:

• TODO: comments it and run to find a problems`

Logs sample for wrong block:

Error: set with wrong blockName settings: 10E - Tenth Edition (blockName = null, but must be Core Set)
Error: set with wrong blockName settings: 2ED - Unlimited Edition (blockName = null, but must be Core Set)
Error: set with wrong blockName settings: 2X2 - Double Masters 2022 (blockName = Reprint, but must be null)
Error: set with wrong blockName settings: 2XM - Double Masters (blockName = Reprint, but must be null)
Error: set with wrong blockName settings: 3ED - Revised Edition (blockName = null, but must be Core Set)

Logs sample for wrong parent set:

Error: set with wrong parentSet settings: WTH - Weatherlight (parentSet = MIR, but must be null)
Error: set with wrong parentSet settings: WWK - Worldwake (parentSet = ZEN, but must be null)
Error: set with wrong parentSet settings: XANA - Arena New Player Experience Extras (parentSet = null, but must be ANA - ArenaNewPlayerExperience.getInstance())
Error: set with wrong parentSet settings: ZNC - Zendikar Rising Commander (parentSet = null, but must be ZNR - ZendikarRising.getInstance())

[brunofpinheiro]

Is anyone working on this? I would like to do it if that's ok.

[xenohedron]

I'm not aware of anyone working on this. Go for it!

[xenohedron]

Okay I'm starting to look at this and I don't think the mtgjson verify really corresponds to how the fields are used internal to xmage:

Block name

• Used for grouping in GUI dropdown for set selection. It's a field in card repository, not sure if used anywhere else?
• Would we have a reason to group some expansion sets that aren't real blocks (e.g. all the duel decks) contrary to mtgjson, or is bringing this fully into alignment the way to go? Note that the GUI doesn't seem to recognize the existing duel decks grouping anyway.
• This is probably safe to implement once tested as a sanity check (screenshot of new dropdown compare to old).
• It's definitely an improvement to not specify single large sets (in the modern era without small sets) as their own block.

Parent set

• It looks like mtgjson is using this to say that a promo set (e.g. Aether Revolt Promos) has a main set (e.g. Aether Revolt) as its parent set, and not connecting small sets to large sets (so Zendikar is not considered the parent set of Worldwake according to mtgjson).
• This is a completely different usage from what xmage has currently.
• XMage has filled out this field with large sets the parent set of small sets in the same block.
• Currently, this info is only used for booster generation.
• Without print run info: if small set doesn't have basic lands, check parent set for basic lands
• With print run info: initialize collator from parent set to put its lands into the boosters as needed
• Note that there are multiple possibilities here: individual small sets might have their own basics, might use basics from the large set in their block, or might not have basics. It's correctly implemented with historical accuracy if the set has a print run set up, otherwise it's an assumption.

So what would happen if we switch meaning of parent set to mtgjson meaning instead?

• No improvements for grouping promos (unless added in future). XMage doesn't currently use that info. Promo sets don't have booster generation.
• Booster collation with print runs is probably broken; the collator won't be able to find all the cards and will likely throw error upon booster generation.
• Booster generation without print runs might be okay, just generated without basic lands (no functional impact, but less accurate)

So I don't think we should change parent set without more research and possible refactoring (e.g. rename current field to basicLandsFromSet and check it manually). Block info should be safe to adjust.

[xenohedron]

I tested the GUI when applying just the block name adjustments. It's not an improvement, as all the recent sets without blocks get buried in the list rather than in chronological order. That part of GUI could use a rework to provide additional categorization.

[JayDi85]

BTW deck editor contains outdated "sets choose dialog" with some limitation (it can't use non standard names for sets). But it has additional checkboxes mode.

Images download dialog contains modern "choose sets dialog" with any text usage and filter/search. So that blocks info can be added later in the new choose sets dialgs as additional text (like release date) or as additional combo/filter.