magefree / mage

Magic Another Game Engine
http://xmage.today
MIT License
1.88k stars 770 forks source link

ETB doubling effects (e.g. Panharmonicon) do not apply to ZONE_CHANGE_GROUP events #10335

Open randomsuspect opened 1 year ago

randomsuspect commented 1 year ago

Title says it all. Someone said it might be because his ability has a new keyword. Either way i m pretty sure i didnt miss anything, and it just did not trigger twice when a token entered the bf.

PurpleCrowbar commented 1 year ago

Additionally, Norn does not prevent triggers of enemy Calgars

PurpleCrowbar commented 1 year ago

Issue appears to be that [[Panharmonicon]], [[Elesh Norn, Mother of Machines]], and [[Torpor Orb]] are all specifically concerned with the ENTERS_THE_BATTLEFIELD event type, but effects of cards like [[Marneus Calgar]] which specify "one or more" tokens being created use the ZONE_CHANGE_GROUP event type

github-actions[bot] commented 1 year ago

Panharmonicon - (Gatherer) (Scryfall) (EDHREC)

{4} Artifact If an artifact or creature entering the battlefield causes a triggered ability of a permanent you control to trigger, that ability triggers an additional time.

Elesh Norn, Mother of Machines - (Gatherer) (Scryfall) (EDHREC)

{4}{W} Legendary Creature — Phyrexian Praetor 4/7 Vigilance If a permanent entering the battlefield causes a triggered ability of a permanent you control to trigger, that ability triggers an additional time. Permanents entering the battlefield don't cause abilities of permanents your opponents control to trigger.

Torpor Orb - (Gatherer) (Scryfall) (EDHREC)

{2} Artifact Creatures entering the battlefield don't cause abilities to trigger.

Marneus Calgar - (Gatherer) (Scryfall) (EDHREC)

{2}{W}{U}{B} Legendary Creature — Astartes Warrior 3/5 Double strike Master Tactician — Whenever one or more tokens enter the battlefield under your control, draw a card. Chapter Master — {6}: Create two 2/2 white Astartes Warrior creature tokens with vigilance.

PurpleCrowbar commented 1 year ago

Also applies to [[Yarok, the Desecrated]]

github-actions[bot] commented 1 year ago

Yarok, the Desecrated - (Gatherer) (Scryfall) (EDHREC)

{2}{B}{G}{U} Legendary Creature — Elemental Horror 3/5 Deathtouch, lifelink If a permanent entering the battlefield causes a triggered ability of a permanent you control to trigger, that ability triggers an additional time.

xenohedron commented 1 year ago

Perhaps the code that fires ZONE_CHANGE_GROUP events should also be firing an ENTERS_THE_BATTLEFIELD event for each permanent in the group? That seems to me like a better strategy than checking multiple event types in each custom class.

xenohedron commented 7 months ago

see #11895 , that scope of rework should address this issue