Connection problems in draft caused <40 card deck submission

[ssk97]

I was having trouble staying connected during a draft and subsequent deckbuilding, disconnecting and reconnecting multiple times. After figuring out which cards I wanted, I saved the deck before adding lands. After that I added the lands, re-saved over the original deck, and submitted. When the game started, I found that the first deck saved was the one I was playing with during the event, even though it was under 40 cards in size (and had never been submitted as it was obviously invalid)!

In addition, during the draft, I once reconnected before the next pack was passed. Upon loading, I saw the pack I had already passed, as if I could pick another card from it. I didn't dare try picking, but that seems like unintended behavior. Once the next pack was passed all returned to normal there.

[JayDi85]

After that I added the lands, re-saved over the original deck, and submitted. When the game started, I found that the first deck saved was the one I was playing with during the event

Outdated (non-submitted) deck problem related to add lands between games, see #11877

In addition, during the draft, I once reconnected before the next pack was passed. Upon loading, I saw the pack I had already passed, as if I could pick another card from it

Interesting bug. Can be related to freeze richman drafts problem. Also can be potentially cheated (need research).

[sprangg]

@JayDi85 When I did the changes to get rid of drafts freezing, I forgot to add them to rich drafts. Additionally this broke rich draft timers, so they're now basically untimed - players have infinite time to make their pick even though the timer is counting down in the UI.

I can't promise a fix for this week but next week I can do it.

I'm not sure if that weird reconnect behavior, where you see the pack that you already made a pick from, is related, but seems worth investigating how it works in general. Iirc it does work in such a way that a player is allowed to only make one pick per pack.

As an aside, it would be nicer if xmage didn't hide the pack you made a pick from. There could be some other way of showing that you made your pick than hiding the whole pack, like greying out the cards.

[JayDi85]

Just for info: current richman freeze on pick waiting (players do not send pick or quit commands, so it can’t continue). Maybe I can look at original draft fixes in #9435 and pick some changes for richman too.

[sprangg]

Just wanna let you know @JayDi85 that I'm too busy to work on rich draft fixes during this week or the next one after all. I'll try again in 2-3 weeks, if you already haven't done everything then.