search

magefree / mage

Magic Another Game Engine
http://xmage.today
MIT License
1.9k stars 776 forks source link

Refactor: group together cards like Gift of the Gargantuan #11389

Closed Susucre closed 11 months ago

Susucre commented 1 year ago

Followup of https://github.com/magefree/mage/commit/d08c61c2adbd5b570fc96ef6b37a119669dd90b5#r131723337

[[Gift of the Gargantuan]] way to select "creature card and/or land card" is nicely done. Grouping the targetting in a common class would make it more easily used as a default if new cards using that templating are added.

Probably excluded from the following list are Alchemized Nahiri and [[Axgard Armory]] (although we could use similar technology for other kind of predicates) https://scryfall.com/search?q=o%3A%2Fan%3F+%5Ba-zA-Z%5D%2B+card+and%5C%2For+an%3F+%5Ba-zA-z%5D%2B+card%2F&unique=cards&as=grid&order=name

github-actions[bot] commented 1 year ago

Gift of the Gargantuan - (Gatherer) (Scryfall) (EDHREC)

{2}{G} Sorcery Look at the top four cards of your library. You may reveal a creature card and/or a land card from among them and put the revealed cards into your hand. Put the rest on the bottom of your library in any order.

Axgard Armory - (Gatherer) (Scryfall) (EDHREC)

Land Axgard Armory enters the battlefield tapped. {T}: Add {W}. {1}{R}{R}{W}, {T}, Sacrifice Axgard Armory: Search your library for an Aura card and/or an Equipment card, reveal them, put them into your hand, then shuffle.

xenohedron commented 1 year ago

We have a general case class e.g. SubTypeAssignment extends RoleAssignment<SubType> already