search

magefree / mage

Magic Another Game Engine
http://xmage.today
MIT License
1.85k stars 762 forks source link

Missing image tooltip hint breaks text boundaries #11827

Open PurpleCrowbar opened 7 months ago

PurpleCrowbar commented 7 months ago

The new missing image hint that shows in the tooltips of cards (added in 34816be) causes a text issue in which text escapes the bounds of the tooltip box. This is more obvious in some cards than others, see the example below with the ooze token from MKM's [[Slime Against Humanity]], a set without token images in XMage yet: image The text going out of bounds also shifts all other right-aligned text on the card to be too far to the right. In the case of the token above, the set code "XMAGE" (the default for tokens not present in the database) and the word "Token" are missing. They're still technically there, but are so far to the right of the tooltip that they are no longer visible.

github-actions[bot] commented 7 months ago

Slime Against Humanity - (Gatherer) (Scryfall) (EDHREC)

{2}{G} Sorcery Create a 0/0 green Ooze creature token with trample. Put X +1/+1 counters on it, where X is two plus the total number of cards you own in exile and in your graveyard that are Oozes or are named Slime Against Humanity. A deck can have any number of cards named Slime Against Humanity.

tiera3 commented 4 weeks ago

In issue 12687, I was talking about the blowup image (off to the right) that gets replaced with hint text when there is no image.. Your picture is just showing the popup hint (which isn't cut off as badly - though still a little).

image