search

magefree / mage

Magic Another Game Engine
http://xmage.today
MIT License
1.8k stars 748 forks source link

Show cards sorted alphabetically when searching opponent's deck (Slaughter Games issue?) #11874

Open sumsarz opened 4 months ago

sumsarz commented 4 months ago

When you're searching a deck with for example Slaughter Games the window for the deck is seemingly randomized, making it hard to get an overview of the contents and quickly find the cards you want to click on (even possible to miss one).

I'd suggest changing to being sorted alphabetical to mirror MTGO behavior.

JayDi85 commented 4 months ago

Are you talking about card selection windows like that?

shot_240229_105326

JayDi85 commented 4 months ago

Choose card name and same dialogs uses auto-sorting: shot_240229_105208 shot_240229_105234

sumsarz commented 4 months ago

Yeah, that card selection window.

But I just noticed Surgical Extraction showed a sorted deck, so maybe it's just Slaughter Games which is weird and doesn't sort?

sumsarz commented 4 months ago

This how it looked when resolving [[Slaughter Games]], the deck in disarray:

image

This is how it looks when resolving Surgical Extraction, the deck is sorted:

image

github-actions[bot] commented 4 months ago

Slaughter Games - (Gatherer) (Scryfall) (EDHREC)

{2}{B}{R} Sorcery This spell can't be countered. Choose a nonland card name. Search target opponent's graveyard, hand, and library for any number of cards with that name and exile them. Then that player shuffles.

sumsarz commented 4 months ago

Looks like the two cards are implemented differently. Slaughter Games uses applySearchAndExile:

image

While Surgical implements it in the card itself:

image

I figure sorting the library is done differently in the implementations somehow.