magefree / mage

Magic Another Game Engine
http://xmage.today
MIT License
1.88k stars 772 forks source link

Targets can't be reselected for Meteor Swarm #12002

Open alexander-novo opened 7 months ago

alexander-novo commented 7 months ago

image

I copied [[Meteor Swarm]] with [[Chandra, Hope's Beacon]]. While attempting to re-select the target, the client told me that the new target wasn't valid no matter what I selected.

github-actions[bot] commented 7 months ago

Meteor Swarm - (Gatherer) (Scryfall) (EDHREC)

{X}{R}{R}{R} Sorcery Meteor Swarm deals 8 damage divided as you choose among X target creatures and/or planeswalkers.

Chandra, Hope's Beacon - (Gatherer) (Scryfall) (EDHREC)

{4}{R}{R} Legendary Planeswalker — Chandra 5 Whenever you cast an instant or sorcery spell, copy it. You may choose new targets for the copy. This ability triggers only once each turn. +2: Add two mana in any combination of colors. +1: Exile the top five cards of your library. Until the end of your next turn, you may cast an instant or sorcery spell from among those exiled cards. −X: Chandra, Hope's Beacon deals X damage to each of up to two targets.

xenohedron commented 7 months ago

I'm guessing the culprit is somewhere in StackObjectImpl::chooseNewTarget, perhaps not working right with TargetAmount or TargetAdjuster for whatever reason. Lots of TODOs in that overly complex method.