Outdated draft cubes must be removed?

magefree / mage

Magic Another Game Engine

http://xmage.today

MIT License

1.8k stars 746 forks source link

Outdated draft cubes must be removed? #12050

Open JayDi85 opened 3 months ago

JayDi85 commented 3 months ago

There are many draft cubes. Each new cube update creates a new draft class instead update existing one.

Examples:

MTGO Legacy Cube 2016 September — must be MTGO Legacy Cube
MTGO Vintage Cube 2013 — must be MTGO Vintage Cube
etc

I don’t think anyone use that old versions. So xmage must contain a single draft cube with dynamic name (name must contains last updated info —so no need to update server config after each new cube version).

TODO:

[ ] make cube name dynamic (loaded from a class, not from config);
[ ] combine all updated versions of the cube to single file with single cube (latest version only);
[ ] delete all old unused draft cubes (keep only latest draft cube version);
[ ] make sure new version will work with old configs (if it contains non existing draft cube records).

Susucre commented 3 months ago

Of note, cubes lists are often kept up to date on Cubecobra those days.

Could add a way to create a cube tournament from a cubecobra url, importing a card list, keeping the ones that are in the database (with the proper set/id if existing, or any one if the card exist but not that version), then creating the tournament with that list.

For instance that's what https://draftmancer.com is doing, and it is very convenient:

That way there would be no need to update the cube list, as the cubecobra list would serve as base.

Just an idea tough, I'm sure it would simplify cube tournament creation.

JayDi85 commented 3 months ago

Cubecobra already has export feature to xmage deck format. Online catalog integration will be part of decks viewer rework.

It can be used in verify tests to check existing cubes -- like mtgjson does for cards:

run cubes verify test;
download known cube files from a website;
compare cards list in downloaded and xmage cube files.

xenohedron commented 3 months ago

I definitely agree these versions shouldn't be separate config entries, and each maintained cube should have a single version that is easy to automatically update from a reliable source.

(I do think there could be some value in maintaining the existing previous versions for historical interest, if it can be done without undue clutter to the codebase.)