magefree / mage

Magic Another Game Engine
http://xmage.today
MIT License
1.88k stars 772 forks source link

Tokens limit must be improved to use additional score #12328

Open JayDi85 opened 5 months ago

JayDi85 commented 5 months ago

Related to #11285

500 tokens per player is big value. The main problem for server stability are token’s triggers/effects, not tokens as is. It’s ok to have 500 Food tokens. But it’s pain to have 10 tokens with multiply effects like [[Parallel Lives]].

Possible solution: use token score instead token amount (+1 from token, +2 from each trigger, +2 from each static ability). It also will work for dynamically added abilities (e.g. for copy tokens). It’s requires some additional calculations but it must be fast.

github-actions[bot] commented 5 months ago

Parallel Lives - (Gatherer) (Scryfall) (EDHREC)

{3}{G} Enchantment If an effect would create one or more tokens under your control, it creates twice that many of those tokens instead.

JayDi85 commented 5 months ago

Another possible solution: use game state’s triggers/effects limit for token creating. Same as above but look at whole game effects amount, not tokens. It also can find a problems with non-discarded effects (if something generates it each turn/transform/cycle/etc).