magefree / mage

Magic Another Game Engine
http://xmage.today
MIT License
1.8k stars 747 forks source link

Rework removing 0-N counters from target. #12370

Open Susucre opened 1 month ago

Susucre commented 1 month ago

https://github.com/magefree/mage/commit/c70dfaf7d1275717386dd0d6e53b171643da81f1#r142643588

Effects that remove some counters of any kind, but of a known quantity, could be cleaned up with cleaner UI and AI usage. The most complex ones can remove counters from a target that can be either a permanent or player.

Hard to pinpoint them in a single search, but this is a start:

https://scryfall.com/search?q=o%3A%22remove+a+counter%22+or+o%3A%22remove+up+to%5B%5E%2C.%5D*counter%22

Susucre commented 1 month ago

RemoveCounterTargetEffect is a good starter point (as of now only work for permanents)