search

magefree / mage

Magic Another Game Engine
http://xmage.today
MIT License
1.8k stars 746 forks source link

image download issue - SLD 209/811 #12511

Open xenohedron opened 1 week ago

xenohedron commented 1 week ago

from 77aba62

Including Norn's 811 SLD variant in the download list caused the 209 SLD variant to not be able to download correctly. Seemed to happen when NON_FULL_USE_VARIOUS was applied. Potentially due to some weirdness regarding 209's URL.

tiera3 commented 1 week ago

With https://github.com/magefree/mage/commit/17507970364e146b73e9926084fd12ef095c9041 and https://github.com/magefree/mage/pull/12508 merged, it should be using https://api.scryfall.com/cards/sld/209?format=image&version=normal&include_variations=true as its second attempt to download the file after the first attempt fails due to this being a phyrexian language card. Was this not the attempted URL?

With only https://github.com/magefree/mage/commit/17507970364e146b73e9926084fd12ef095c9041 , the second URL attempted should have been https://api.scryfall.com/cards/sld/209?format=image&version=normal which should have succeeded. Though if it failed, it should have progressed to a third URL to attempt (that should fail for this card).