magefree / mage

Magic Another Game Engine
http://xmage.today
MIT License
1.84k stars 759 forks source link

GUI - stacked tokens in combat #12513

Open xenohedron opened 2 months ago

xenohedron commented 2 months ago

Related to the recent improvements from #12256 and similar

It can be quite difficult to identify individual tokens when trying to attack, block, or target.

Not sure if it will become easier with practice but we're getting some feedback in XDHS that it is confusing. So I'm opening an issue for discussion on the topic.

duelcastermage commented 2 months ago

Basically what you said there. Hard to identify individual tokens to click on for attacks, blocks, or targeting.

tiera3 commented 2 months ago

Arena unstacks tokens when they differ from others - ie ones that are attacking, ones that are blocking (different creatures), ones that have been targetted by an effect. Is that not easy to do in xmage?

grimreap124 commented 2 months ago

I believe @JayDi85 had something to split the attack arrows but I can't seem to find the PR or issue

grimreap124 commented 2 months ago

12259

grimreap124 commented 2 months ago

Arena unstacks tokens when they differ from others - ie ones that are attacking, ones that are blocking (different creatures), ones that have been targetted by an effect. Is that not easy to do in xmage?

I like that idea, I'll have a look into that tonight

JayDi85 commented 2 months ago

Make some screenshots with bad use cases (hard to identify attackers/blockers/selections). It can be useful.

grimreap124 commented 2 months ago

I can post some later. After just testing stacking if targets are the same it doesn't work because it doesn't redraw the battlefield when an attack is declared. Do you know how easy that would be to add?

JayDi85 commented 2 months ago

I think it’s same problem with two different places to compare from last time, not a redraw (battlefield must be updated after each attacker/blocker declare).

grimreap124 commented 2 months ago

I was saying redraw but meant update. Do you know where I could add that trigger?

grimreap124 commented 2 months ago

Where the stacking happens in CardPluginImpl I can't find anything related to the target of the MagePermanent we are trying to sort into stacks.

JayDi85 commented 2 months ago

Found screenshot example:

image

JayDi85 commented 2 months ago

Where the stacking happens in CardPluginImpl I can't find anything related

PermanentView must be improved to store two additional fields (isAttacking and isBlocking)

grimreap124 commented 2 months ago

Where the stacking happens in CardPluginImpl I can't find anything related

PermanentView must be improved to store two additional fields (isAttacking and isBlocking)

If you can point me to where I would set this I can have a go at implementing it

tiera3 commented 2 months ago

Posted by Nibiru in xdhs image He is complaigning about transformed (ie creature) and not-transformed (ie not creature) incubator tokens being stacked together.

I'm also concerned that perhaps ones with differing numbers of +1/+1 counters may also be stacked together.

Susucre commented 2 months ago

PermanentView must be improved to store two additional fields (isAttacking and isBlocking)

in addition, detail on what/who is attacked/blocked is required to differentiate situations.

Grath commented 2 months ago

This isn't per se a stacked tokens issue, but something that would help with stacked tokens: It would be fantastic to be able to select multiple permanents by clicking and dragging a rectangle over them, similar to how you can select several cards in the deck builder. I was playing my Atraxa, Praetors' Voice (proliferate) deck, had Cathars' Crusade out and it was a pain in the ass clicking on each of 15-20 tokens to proliferate their +1/+1 counters. If this could be done for attacking/blocking as well, that might resolve some of the current pain points with handling stacked tokens in combat.