magefree / mage

Magic Another Game Engine
http://xmage.today
MIT License
1.91k stars 778 forks source link

Add a preferred printing feature to Xmage deckbuilder #12628

Open Svyatoslav28597 opened 3 months ago

Svyatoslav28597 commented 3 months ago

If you create your decks outside of xmage (On scryfall or Moxfield, as an exaple) and load them into xmage - you get a wild mess of images in your deck, some secret lairs, etched foils, chinese prints, normal cards, etc. And that happens every time you load your deck, so setting images you like won't help, especially if you change a lot of cards and update frequently It would be nice if you could set each card to use specific printing every time it shows up in your deck after loading, in draft, everywhere

tiera3 commented 3 months ago

I don't know what exports are like from moxfield, but if you can export with set information (MTGA style) and use the import feature in the deck editor, it preserves the selected printings.

xenohedron commented 3 months ago

Yep, the request is for a feature that xmage supports already. The described issue probably has to do with the method of import/export, or support for specifying printings from the third party service. To move forward we'd need a more detailed description of exact steps to reproduce.

siyiye commented 3 months ago

If you create your decks outside of xmage (On scryfall or Moxfield, as an exaple) and load them into xmage - you get a wild mess of images in your deck, some secret lairs, etched foils, chinese prints, normal cards, etc. And that happens every time you load your deck, so setting images you like won't help, especially if you change a lot of cards and update frequently It would be nice if you could set each card to use specific printing every time it shows up in your deck after loading, in draft, everywhere

I understand what you mean: players can customize their favorite illustration version instead of randomly specifying it when importing. For example: I only like the new version of the large-screen tron ​​picture

Svyatoslav28597 commented 3 months ago

I usually do decks in Moxfield and import them to xmage. Moxfield offers 3 ways to export (Copy For Moxfield/Copy for MTGA/Copy for MTGO) and only copy for MTGO correctly imports to Xmage, since other two options load cards to sideboard or don't load them at all. While copy for MTGO correctly imports decks - the printings seem to be absolutely random and with each deck update on moxfield - you import cards again and see wierd bunch of secret lairs and chinese cards. Not sure if this is a quirk of moxfield, or I am missing something which solves this issue

JayDi85 commented 3 months ago

For info: moxfield not fully support mtga format (export without set info). More details here #12304

PurpleCrowbar commented 2 months ago

Card import preferences could be stored in key/val pairs where the key is the card's name and the value is a string containing the set and card number separated by some delimiter e.g. {"Go for the Throat", "40K,201"} would reference this specific card printing.

Would it be fine to store these as preferences, maybe a new key in the registry inside HKEY_CURRENT_USER\SOFTWARE\JavaSoft\Prefs\mage\client called "importPreferences" which would contain all the pairs?

JayDi85 commented 2 months ago

It's not about import only -- it's about deck edition too. There are already exists feature to make cards oldest and non-promo: shot_240905_040619 shot_240905_041522

So: