magefree / mage

Magic Another Game Engine
http://xmage.today
MIT License
1.9k stars 773 forks source link

Scrambleverse not random #12679

Open PurpleCrowbar opened 2 months ago

PurpleCrowbar commented 2 months ago

[[Scrambleverse]] causes each nonland permanent to be given to a random player. In XMage, however, all of the nonland permanents are given to the player who cast the spell. On L60 below, players.get(RandomUtil.nextInt(count)) gets a random valid player, but that value is seemingly ignored. Manual testing with things like players.get(1) or players.get(2) instead yielded the exact same result, all permanents just go to the person who cast the spell.

https://github.com/magefree/mage/blob/19e7436d4ea0f552dfb759d96dae81b36bd946bf/Mage.Sets/src/mage/cards/s/Scrambleverse.java#L55-L66

Maybe a problem with GainControlTargetEffect.

github-actions[bot] commented 2 months ago

Scrambleverse - (Gatherer) (Scryfall) (EDHREC)

{6}{R}{R} Sorcery For each nonland permanent, choose a player at random. Then each player gains control of each permanent for which they were chosen. Untap those permanents.