magefree / mage

Magic Another Game Engine
http://xmage.today
MIT License
1.91k stars 778 forks source link

Couldn't unmount zip files when downloading images #12833

Open jmba98 opened 2 months ago

jmba98 commented 2 months ago

Error type: Couldn't unmount zip files net.java.truevfs.kernel.spec.FsSyncException: zip:file:/C:/Users/jmba9/OneDrive/Desktop/XMage2024/xmage/mage-client/plugins/images/VIS.zip!/ - FsSyncException Client version: 1.4.54-V1 (build: 2024-09-08 18:14)

zip:file:/C:/Users/jmba9/OneDrive/Desktop/XMage2024/xmage/mage-client/plugins/images/VIS.zip!/

Stack trace: net.java.truevfs.kernel.impl.TargetArchiveController.close(TargetArchiveController.java:434) net.java.truevfs.kernel.impl.TargetArchiveController.sync(TargetArchiveController.java:327) net.java.truevfs.kernel.impl.ResourceController.sync(ResourceController.java:95) net.java.truevfs.kernel.impl.CacheController.sync(CacheController.java:128) net.java.truevfs.kernel.impl.SyncController.doSync(SyncController.java:263) net.java.truevfs.kernel.impl.SyncController.sync(SyncController.java:243) net.java.truevfs.kernel.impl.LockController$10.call(LockController.java:212) net.java.truevfs.kernel.impl.LockController$10.call(LockController.java:208) net.java.truevfs.kernel.impl.LockingStrategy$4.call(LockingStrategy.java:142) net.java.truevfs.kernel.impl.LockController.sync(LockController.java:208) and other 13 lines Root caused by: sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:79) sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:97) sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:102) sun.nio.fs.WindowsFileSystemProvider.newByteChannel(WindowsFileSystemProvider.java:230) java.nio.file.Files.newByteChannel(Files.java:361) java.nio.file.Files.newByteChannel(Files.java:407) java.nio.file.spi.FileSystemProvider.newInputStream(FileSystemProvider.java:384) java.nio.file.Files.newInputStream(Files.java:152) net.java.truevfs.driver.file.FileInputSocket.stream(FileInputSocket.java:45) net.java.truecommons.cio.IoSockets$InputAdapter.stream(IoSockets.java:61) and other 37 lines

xenohedron commented 2 months ago

Try running as admin, some users have reported that fixes the problem (or could be coincidence for intermittent error)

JayDi85 commented 2 months ago

It’s random error related to system performance (race condition in multithreaded code). There are must be some un-synced code in xmage or in truevfs library (maybe it has some limitation or special settings, need research).

p.s. it’s about unsaved data for one of the set. Not critical for a user - just run download in next app run or restart.

xenohedron commented 1 month ago

@JayDi85 if it's an intermittent error with no true fix, it possible to get some error handling on this at least?

JayDi85 commented 1 month ago

It’s under progress