magefree / mage

Magic Another Game Engine
http://xmage.today
MIT License
1.9k stars 773 forks source link

Bloomburrow offspring creatures lack special "offspring token" images #12904

Open Svyatoslav28597 opened 1 month ago

Svyatoslav28597 commented 1 month ago

To elaborate on the issue: All bloomburrow creatures have special token copies reserved to the paying offspring cost. While offspring seems to be working perfectly in the xmage - all copies just use normal image of the creature. Would it be possible for offspring tokens to use special images, or this would require too much refactoring and fixing problems with things like copying creatues? This also may be a bit tricky to add due to things like [[Cottontail Caretaker]] and [[Zinnia, Valley's Voice]] adding offspring to cards which normally don't have it

Offspring Token: image Offspring token in game: image

github-actions[bot] commented 1 month ago

Cottontail Caretaker - (Gatherer) (Scryfall) (EDHREC)

{1}{W} Creature — Rabbit Citizen 2/2 When Cottontail Caretaker enters, choose a white creature card in your hand. That card perpetually gains offspring {1}.

Zinnia, Valley's Voice - (Gatherer) (Scryfall) (EDHREC)

{U}{R}{W} Legendary Creature — Bird Bard 1/3 Flying Zinnia, Valley's Voice gets +X/+0, where X is the number of other creatures you control with base power 1. Creature spells you cast have offspring {2}. (You may pay an additional {2} as you cast a creature spell. If you do, when that creature enters, create a 1/1 token copy of it.)

JayDi85 commented 1 month ago

It’s useless to add cause will support little amount of all possible images. Same as tokens from Embalm ability like [[Sacred Cat]].

github-actions[bot] commented 1 month ago

Sacred Cat - (Gatherer) (Scryfall) (EDHREC)

{W} Creature — Cat 1/1 Lifelink Embalm {W} ({W}, Exile this card from your graveyard: Create a token that's a copy of it, except it's a white Zombie Cat with no mana cost. Embalm only as a sorcery.)

ssk97 commented 1 month ago

It’s useless to add cause will support little amount of all possible images. Same as tokens from Embalm ability like [[Sacred Cat]].

I strongly disagree that this is useless. Those token images exist, why shouldn't we use them? You fixed this same issue yourself in #3201, no?

JayDi85 commented 1 month ago

I strongly disagree that this is useless. Those token images exist, why shouldn't we use them? You fixed this same issue yourself in #3201

Nope, it's old code from old days with direct images control and miss token images from unsupported cards. Embalm tokens doesn't work in current code (it use same logic as offspring -- copied token from a card). You will need to inject images checking and setup code directly to card/ability logic with additional checking of supported and non supported cards. It's possible, but sound weird.

ssk97 commented 1 month ago

Nope, it's old code from old days with direct images control and miss token images from unsupported cards. Embalm tokens doesn't work in current code (it use same logic as offspring -- copied token from a card). You will need to inject images checking and setup code directly to card/ability logic with additional checking of supported and non supported cards. It's weird.

It's not currently an easy thing to do, explaining why it's not currently working, but it's something that we would like to have working if we could. Seems to me like having it as an open issue is correct, even if it's not being actively worked on.