magefree / mage

Magic Another Game Engine
http://xmage.today
MIT License
1.91k stars 782 forks source link

Combat Celebrant can be exerted multiple times per turn with vigilance #3345

Closed DavidHWhite closed 7 years ago

DavidHWhite commented 7 years ago

If combat celebrant is given vigilance, it can be exerted repeatedly in a single turn, effectively allowing for infinite combat steps unless it's killed. However, as the card text states, it should only be exertable if it hasn't been previously exerted that turn.

drmDev commented 7 years ago

we have tried many times to duplicate this issue but have been unable to. see https://github.com/magefree/mage/issues/3195 and the associated tests. need a log showing infinite combat steps to investigate further

drmDev commented 7 years ago

Attempted again with Always Watching out and was unable to exert Celebrant more than once. As mentioned in the issue linked above, need a log to investigate further. Unable to duplicate still. Celebrant can still attack again in the additional combat phase, just cannot exert again in the same turn.

DavidHWhite commented 7 years ago

Opponent played Combat Celebrant, then next turn played Arlinn Kord and used her +1 to give Combat Celebrant vigilance. He then attacked and exerted, then in the second combat phase attacked again and was once more given the option to exert. He did so just to see if it would actually work. It did, giving him a third combat phase, during which he didn't attack because he recognized that it was a glitch. I thus don't know whether it would have allowed him to exert a third time, but I doubt it would be any different than the second time. Here's the relevant section of the log:

7:43 PM: Mastaalucard puts Arlinn Kord [756] from stack onto the Battlefield 7:43 PM: Mastaalucard activates: Until end of turn, up to one target creature gets +2/+2 and gains vigilance and haste. from Arlinn Kord [756] targeting Combat Celebrant [393] 7:43 PM: Mastaalucard exerted Combat Celebrant 7:43 PM: Mastaalucard attacks with 1 creature 7:43 PM: Ability triggers: Combat Celebrant [393] - When Combat Celebrant [393] becomes exerted, untap all other creature you control you control and after this phase, there is an additional combat phase. 7:44 PM: Attacker: Combat Celebrant [393] (6/3) unblocked 7:44 PM: MaygeKyatt loses 6 life 7:44 PM: Mastaalucard starts an additional Combat phase 7:44 PM: Mastaalucard exerted Combat Celebrant 7:44 PM: Mastaalucard attacks with 1 creature 7:44 PM: Ability triggers: Combat Celebrant [393] - When Combat Celebrant [393] becomes exerted, untap all other creature you control you control and after this phase, there is an additional combat phase. 7:45 PM: Attacker: Combat Celebrant [393] (6/3) unblocked 7:45 PM: MaygeKyatt loses 6 life 7:45 PM: Mastaalucard starts an additional Combat phase 7:45 PM: Mastaalucard attacks with 0 creatures

drmDev commented 7 years ago

Still unable to duplicate. It's possible this was an issue in v4 but not an issue on the current code in master which be released in v5 (and what I'm testing against).

celebrant-arlinn Was never given the option to be able to exert a second time - screenshot taken at the point where I would usually be given the option to.

Does your client and server version show 1.4.23v4 as well?

DavidHWhite commented 7 years ago

Yes. Also, as I said, it was my opponent playing the cards, not me, so I don't know all the details.

drmDev commented 7 years ago

unable to reproduce

jsut commented 6 years ago

I just ran into this in a game. And this is probably going to be coming up a lot due to the success of the UR GPG deck at GP seattle on the weekend. I was not playing the celebrants, but it did say in the on screen log that his three celebrants, all of which had been exerted previously, were once again exerted. I am suspicious that it actually did to everything right, aside from reporting that the celebrants were exerted when they couldn't have been.

Here's roughly how it went down: